database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Rename bytea_agg to string_agg and add delimiter argument

Browse Source 
Per mailing list discussion, we would like to keep the bytea functions
parallel to the text functions, so rename bytea_agg to string_agg,
which already exists for text.

Also, to satisfy the rule that we don't want aggregate functions of
the same name with a different number of arguments, add a delimiter
argument, just like string_agg for text already has.
This commit is contained in:
Peter Eisentraut
2012-04-13 21:36:59 +03:00
parent 64e1309c76
commit c0cc526e8b
8 changed files with 52 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/utils/adt/varlena.c
View File

@ -397,7 +397,7 @@ byteasend(PG_FUNCTION_ARGS)
}
Datum
bytea_agg_transfn(PG_FUNCTION_ARGS)
bytea_string_agg_transfn(PG_FUNCTION_ARGS)
{
StringInfo state;
@ -408,21 +408,28 @@ bytea_agg_transfn(PG_FUNCTION_ARGS)
{
bytea *value = PG_GETARG_BYTEA_PP(1);
/* On the first time through, we ignore the delimiter. */
if (state == NULL)
state = makeStringAggState(fcinfo);
else if (!PG_ARGISNULL(2))
{
bytea *delim = PG_GETARG_BYTEA_PP(2);
appendBinaryStringInfo(state, VARDATA_ANY(delim), VARSIZE_ANY_EXHDR(delim));
}
appendBinaryStringInfo(state, VARDATA_ANY(value), VARSIZE_ANY_EXHDR(value));
}
/*
* The transition type for bytea_agg() is declared to be "internal",
* The transition type for string_agg() is declared to be "internal",
* which is a pass-by-value type the same size as a pointer.
*/
PG_RETURN_POINTER(state);
}
Datum
bytea_agg_finalfn(PG_FUNCTION_ARGS)
bytea_string_agg_finalfn(PG_FUNCTION_ARGS)
{
StringInfo state;