Preventive maintenance in advance of pgindent run.

Reformat various places in which pgindent will make a mess, and
fix a few small violations of coding style that I happened to notice
while perusing the diffs from a pgindent dry run.

There is one actual bug fix here: the need-to-enlarge-the-buffer code
path in icu_convert_case was obviously broken.  Perhaps it's unreachable
in our usage?  Or maybe this is just sadly undertested.

src/include/replication/logicalproto.h

@@ -30,8 +30,10 @@
 /* Tuple coming via logical replication. */
 typedef struct LogicalRepTupleData
 {
-	char   *values[MaxTupleAttributeNumber];	/* value in out function format or NULL if values is NULL */
-	bool	changed[MaxTupleAttributeNumber];	/* marker for changed/unchanged values */
+	/* column values in text format, or NULL for a null value: */
+	char   *values[MaxTupleAttributeNumber];
+	/* markers for changed/unchanged column values: */
+	bool	changed[MaxTupleAttributeNumber];
 } LogicalRepTupleData;
 
 typedef uint32	LogicalRepRelId;