Preventive maintenance in advance of pgindent run.

Reformat various places in which pgindent will make a mess, and
fix a few small violations of coding style that I happened to notice
while perusing the diffs from a pgindent dry run.

There is one actual bug fix here: the need-to-enlarge-the-buffer code
path in icu_convert_case was obviously broken.  Perhaps it's unreachable
in our usage?  Or maybe this is just sadly undertested.

src/backend/replication/logical/snapbuild.c

@@ -176,7 +176,7 @@ struct SnapBuild
 	 */
 	TransactionId initial_xmin_horizon;
 
-	/* Indicates if we are building full snapshot or just catalog one .*/
+	/* Indicates if we are building full snapshot or just catalog one. */
 	bool		building_full_snapshot;
 
 	/*

src/backend/replication/pgoutput/pgoutput.c

@@ -221,14 +221,15 @@ pgoutput_begin_txn(LogicalDecodingContext *ctx, ReorderBufferTXN *txn)
 		OutputPluginWrite(ctx, false);
 		OutputPluginPrepareWrite(ctx, true);
 
-		/*
-		 * XXX: which behaviour we want here?
+		/*----------
+		 * XXX: which behaviour do we want here?
 		 *
 		 * Alternatives:
 		 *  - don't send origin message if origin name not found
 		 *    (that's what we do now)
 		 *  - throw error - that will break replication, not good
 		 *  - send some special "unknown" origin
+		 *----------
 		 */
 		if (replorigin_by_oid(txn->origin_id, true, &origin))
 			logicalrep_write_origin(ctx->out, origin, txn->origin_lsn);