database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

When a TAP file has non-zero exit status, retain temporary directories.

Browse Source 
PostgresNode already retained base directories in such cases.  Stop
using $SIG{__DIE__}, which is redundant with the exit status check, in
lieu of proliferating it to TestLib.  Back-patch to 9.6, where commit
88802e0680 introduced retention on
failure.

Reviewed by Daniel Gustafsson.

Discussion: https://postgr.es/m/20200202170155.GA3264196@rfd.leadboat.com
This commit is contained in:
Noah Misch
2020-02-05 08:26:41 -08:00
parent 815c2f0972
commit bf989aaf35
2 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/perl/TestLib.pm
View File

@ -183,8 +183,13 @@ INIT
END
{
# Preserve temporary directory for this test on failure
$File::Temp::KEEP_ALL = 1 unless all_tests_passing();
# Test files have several ways of causing prove_check to fail:
# 1. Exit with a non-zero status.
# 2. Call ok(0) or similar, indicating that a constituent test failed.
# 3. Deviate from the planned number of tests.
#
# Preserve temporary directories after (1) and after (2).
$File::Temp::KEEP_ALL = 1 unless $? == 0 && all_tests_passing();
}
=pod