1
0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00

Suppress more variable-set-but-not-used warnings from clang 15.

Mop up assorted set-but-not-used warnings in the back branches.
This includes back-patching relevant fixes from commit 152c9f7b8
the rest of the way, but there are also several cases that did not
appear in HEAD.  Some of those we'd fixed in a retail way but not
back-patched, and others I think just got rewritten out of existence
during nearby refactoring.

While here, also back-patch b1980f6d0 (PL/Tcl: Fix compiler warnings
with Tcl 8.6) into 9.2, so that that branch compiles warning-free
with modern Tcl.

Per project policy, this is a candidate for back-patching into
out-of-support branches: it suppresses annoying compiler warnings
but changes no behavior.  Hence, back-patch all the way to 9.2.

Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2022-09-21 13:52:38 -04:00
parent 8c8ee5c991
commit bf21612344
7 changed files with 7 additions and 19 deletions

View File

@ -95,12 +95,10 @@ crc32_sz(char *buf, int size)
{
unsigned int crc = ~((unsigned int) 0);
char *p;
int len,
nr;
int nr;
len = 0;
nr = size;
for (len += nr, p = buf; nr--; ++p)
for (p = buf; nr--; ++p)
_CRC32_(crc, *p);
return ~crc;
}

View File

@ -103,12 +103,10 @@ ltree_crc32_sz(char *buf, int size)
{
unsigned int crc = ~((unsigned int) 0);
char *p;
int len,
nr;
int nr;
len = 0;
nr = size;
for (len += nr, p = buf; nr--; ++p)
for (p = buf; nr--; ++p)
_CRC32_(crc, TOLOWER((unsigned int) *p));
return ~crc;
}