From beb09e9117353f985c9aad6d5c6761193737da74 Mon Sep 17 00:00:00 2001 From: Fujii Masao Date: Tue, 9 Jun 2026 08:18:41 +0900 Subject: [PATCH] Use correct type for catalog_xmin Commit 85c17f6 mistakenly declared a variable storing catalog_xmin as XLogRecPtr, even though catalog_xmin is a TransactionId. This caused no functional issue, but the type was clearly incorrect. Therefore, this commit fixes it to use the correct type TransactionId instead, and backpatch to v17 where the issue was introduced. Author: Imran Zaheer Reviewed-by: Ashutosh Bapat Reviewed-by: Fujii Masao Discussion: https://postgr.es/m/CA+UBfa=mNeLt-4BFjEP4tqdDsnq+oMqqPr7fd9Wji2_9YXmQdA@mail.gmail.com --- src/backend/replication/logical/slotsync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/logical/slotsync.c b/src/backend/replication/logical/slotsync.c index 3cbcd77d12f..bc42d74fec2 100644 --- a/src/backend/replication/logical/slotsync.c +++ b/src/backend/replication/logical/slotsync.c @@ -282,7 +282,7 @@ update_local_synced_slot(RemoteSlot *remote_slot, Oid remote_dbid, { XLogRecPtr old_confirmed_lsn = slot->data.confirmed_flush; XLogRecPtr old_restart_lsn = slot->data.restart_lsn; - XLogRecPtr old_catalog_xmin = slot->data.catalog_xmin; + TransactionId old_catalog_xmin = slot->data.catalog_xmin; LogicalSlotAdvanceAndCheckSnapState(remote_slot->confirmed_lsn, found_consistent_snapshot);