database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-22 02:52:08 +03:00
Code Activity

Remove two_phase variable from CreateReplicationSlotCmd struct.

Browse Source 
Commit 19890a064e added the option to enable two_phase commits via
pg_create_logical_replication_slot but didn't extend the support of same
in replication protocol. However, by mistake, it added the two_phase
variable in CreateReplicationSlotCmd which is required only when we extend
the replication protocol.

Reported-by: Jeff Davis
Author: Ajin Cherian
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com
This commit is contained in:
Amit Kapila
2021-06-07 09:32:06 +05:30
parent f3baaf28a6
commit be57f21650
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/replication/walsender.c
View File

@ -954,7 +954,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)
*/ */
ReplicationSlotCreate(cmd->slotname, true, ReplicationSlotCreate(cmd->slotname, true,
cmd->temporary ? RS_TEMPORARY : RS_EPHEMERAL, cmd->temporary ? RS_TEMPORARY : RS_EPHEMERAL,
cmd->two_phase); false);
} }
if (cmd->kind == REPLICATION_KIND_LOGICAL) if (cmd->kind == REPLICATION_KIND_LOGICAL)

1
src/include/nodes/replnodes.h
View File

@ -56,7 +56,6 @@ typedef struct CreateReplicationSlotCmd
ReplicationKind kind; ReplicationKind kind;
char *plugin; char *plugin;
bool temporary; bool temporary;
bool two_phase;
List *options; List *options;
} CreateReplicationSlotCmd; } CreateReplicationSlotCmd;