database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Delete the temporary file used in buffered GiST build, after the build.

Browse Source 
There were two bugs here: We forgot to call gistFreeBuildBuffers() function
at the end of build, and we passed interXact == true to BufFileCreateTemp,
so the file wasn't automatically cleaned up at end-of-transaction either.
This commit is contained in:
Heikki Linnakangas
2012-05-30 11:58:54 +03:00
parent 4317e0246c
commit be02b16826
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/access/gist/gistbuild.c
View File

@ -214,6 +214,7 @@ gistbuild(PG_FUNCTION_ARGS)
{ {
elog(DEBUG1, "all tuples processed, emptying buffers"); elog(DEBUG1, "all tuples processed, emptying buffers");
gistEmptyAllBuffers(&buildstate); gistEmptyAllBuffers(&buildstate);
gistFreeBuildBuffers(buildstate.gfbb);
} }
/* okay, all heap tuples are indexed */ /* okay, all heap tuples are indexed */

2
src/backend/access/gist/gistbuildbuffers.c
View File

@ -58,7 +58,7 @@ gistInitBuildBuffers(int pagesPerBuffer, int levelStep, int maxLevel)
* Create a temporary file to hold buffer pages that are swapped out of * Create a temporary file to hold buffer pages that are swapped out of
* memory. * memory.
*/ */
gfbb->pfile = BufFileCreateTemp(true); gfbb->pfile = BufFileCreateTemp(false);
gfbb->nFileBlocks = 0; gfbb->nFileBlocks = 0;
/* Initialize free page management. */ /* Initialize free page management. */