database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-22 12:22:45 +03:00
Code Activity

pgstat: stats collector references in comments.

Browse Source 
Soon the stats collector will be no more, with statistics instead getting
stored in shared memory. There are a lot of references to the stats collector
in comments. This commit replaces most of these references with "cumulative
statistics system", with the remaining ones getting replaced as part of
subsequent commits.

This is done separately from the - quite large - shared memory statistics
patch to make review easier.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de
Discussion: https://postgr.es/m/20220308205351.2xcn6k4x5yivcxyd@alap3.anarazel.de
This commit is contained in:
Andres Freund
2022-04-06 13:56:06 -07:00
parent ab62a642d5
commit bdbd3d9064
31 changed files with 95 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/postmaster/walwriter.c
View File

@@ -257,7 +257,7 @@ WalWriterMain(void)
else if (left_till_hibernate > 0)
left_till_hibernate--;
/* Send WAL statistics to the stats collector */
/* report pending statistics to the cumulative stats system */
pgstat_send_wal(false);
/*
@@ -295,12 +295,11 @@ HandleWalWriterInterrupts(void)
if (ShutdownRequestPending)
{
/*
* Force to send remaining WAL statistics to the stats collector at
* process exit.
* Force reporting remaining WAL statistics at process exit.
*
* Since pgstat_send_wal is invoked with 'force' is false in main loop
* to avoid overloading to the stats collector, there may exist unsent
* stats counters for the WAL writer.
* to avoid overloading the cumulative stats system, there may exist
* unreported stats counters for the WAL writer.
*/
pgstat_send_wal(true);