database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

amcheck: Add additional TOAST pointer checks.

Browse Source 
Expand the checks of toasted attributes to complain if the rawsize is
overlarge.  For compressed attributes, also complain if compression
appears to have expanded the attribute or if the compression method is
invalid.

Mark Dilger, reviewed by Justin Pryzby, Alexander Alekseev, Heikki
Linnakangas, Greg Stark, and me.

Discussion: http://postgr.es/m/8E42250D-586A-4A27-B317-8B062C3816A8@enterprisedb.com
This commit is contained in:
Robert Haas
2021-11-05 09:17:40 -04:00
parent db7d1a7b05
commit bd807be693
2 changed files with 67 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/bin/pg_amcheck/t/004_verify_heapam.pl
View File

@ -218,7 +218,7 @@ my $rel = $node->safe_psql('postgres',
my $relpath = "$pgdata/$rel";
# Insert data and freeze public.test
use constant ROWCOUNT => 16;
use constant ROWCOUNT => 18;
$node->safe_psql(
'postgres', qq(
INSERT INTO public.test (a, b, c)
@ -297,7 +297,7 @@ close($file)
$node->start;
# Ok, Xids and page layout look ok. We can run corruption tests.
plan tests => 19;
plan tests => 21;
# Check that pg_amcheck runs against the uncorrupted table without error.
$node->command_ok(
@ -504,7 +504,7 @@ for (my $tupidx = 0; $tupidx < ROWCOUNT; $tupidx++)
push @expected,
qr/${header}multitransaction ID 4 equals or exceeds next valid multitransaction ID 1/;
}
elsif ($offnum == 15) # Last offnum must equal ROWCOUNT
elsif ($offnum == 15)
{
# Set both HEAP_XMAX_COMMITTED and HEAP_XMAX_IS_MULTI
$tup->{t_infomask} |= HEAP_XMAX_COMMITTED;
@ -514,6 +514,24 @@ for (my $tupidx = 0; $tupidx < ROWCOUNT; $tupidx++)
push @expected,
qr/${header}multitransaction ID 4000000000 precedes relation minimum multitransaction ID threshold 1/;
}
elsif ($offnum == 16)
{
# Set raw size too large
$tup->{c_va_rawsize} = 1073741824;
$header = header(0, $offnum, 2);
push @expected,
qr/${header}toast value \d+ rawsize 1073741824 exceeds limit 1073741823/;
}
elsif ($offnum == 17) # Last offnum should equal ROWCOUNT-1
{
# Set raw size too small.
$tup->{c_va_rawsize} = 9998;
$header = header(0, $offnum, 2);
push @expected,
qr/${header}toast value \d+ external size 10000 exceeds maximum expected for rawsize 9998/;
}
write_tuple($file, $offset, $tup);
}
close($file)