database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

Don't propagate a null subtransaction snapshot up to parent transaction.

Browse Source 
This oversight could cause logical decoding to fail to decode an outer
transaction containing changes, if a subtransaction had an XID but no
actual changes.  Per bug #14279 from Marko Tiikkaja.  Patch by Marko
based on analysis by Andrew Gierth.

Discussion: <20160804191757.1430.39011@wrigleys.postgresql.org>
This commit is contained in:
Tom Lane
2016-08-07 13:15:55 -04:00
parent 3676631c68
commit bcbecbce2f
3 changed files with 40 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
contrib/test_decoding/sql/xact.sql
View File

@ -3,10 +3,10 @@ SET synchronous_commit = on;
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding');
-- bug #13844, xids in non-decoded records need to be inspected
CREATE TABLE xact_test(data text);
INSERT INTO xact_test VALUES ('before-test');
-- bug #13844, xids in non-decoded records need to be inspected
BEGIN;
-- perform operation in xact that creates and logs xid, but isn't decoded
SELECT * FROM xact_test FOR UPDATE;
@ -17,6 +17,17 @@ COMMIT;
-- and now show those changes
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
-- bug #14279, do not propagate null snapshot from subtransaction
BEGIN;
-- first insert
INSERT INTO xact_test VALUES ('main-txn');
SAVEPOINT foo;
-- now perform operation in subxact that creates and logs xid, but isn't decoded
SELECT 1 FROM xact_test FOR UPDATE LIMIT 1;
COMMIT;
-- and now show those changes
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
DROP TABLE xact_test;
SELECT pg_drop_replication_slot('regression_slot');