database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-11 10:01:57 +03:00
Code Activity

Avoid NullTest deduction for clone clauses

Browse Source 
In commit b262ad440, we introduced an optimization that reduces an IS
NOT NULL qual on a column defined as NOT NULL to constant true, and an
IS NULL qual on a NOT NULL column to constant false, provided we can
prove that the input expression of the NullTest is not nullable by any
outer join.  This deduction happens after we have generated multiple
clones of the same qual condition to cope with commuted-left-join
cases.

However, performing the NullTest deduction for clone clauses can be
unsafe, because we don't have a reliable way to determine if the input
expression of a NullTest is non-nullable: nullingrel bits in clone
clauses may not reflect reality, so we dare not draw conclusions from
clones about whether Vars are guaranteed not-null.

To fix, we check whether the given RestrictInfo is a clone clause in
restriction_is_always_true and restriction_is_always_false, and avoid
performing any reduction if it is.

There are several ensuing plan changes in predicate.out, and we have
to modify the tests to ensure that they continue to test what they are
intended to.  Additionally, this fix causes the test case added in
f00ab1fd1 to no longer trigger the bug that commit fixed, so we also
remove that test case.

Back-patch to v17 where this bug crept in.

Reported-by: Ronald Cruz <cruz@rentec.com>
Diagnosed-by: Tom Lane <tgl@sss.pgh.pa.us>
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/f5320d3d-77af-4ce8-b9c3-4715ff33f213@rentec.com
Backpatch-through: 17
This commit is contained in:
Richard Guo
2025-03-04 16:17:19 +09:00
parent d6dd2a02ba
commit bc5a08af3c
3 changed files with 187 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/optimizer/plan/initsplan.c
View File

@ -2740,6 +2740,15 @@ bool
restriction_is_always_true(PlannerInfo *root,
RestrictInfo *restrictinfo)
{
/*
* For a clone clause, we don't have a reliable way to determine if the
* input expression of a NullTest is non-nullable: nullingrel bits in
* clone clauses may not reflect reality, so we dare not draw conclusions
* from clones about whether Vars are guaranteed not-null.
*/
if (restrictinfo->has_clone || restrictinfo->is_clone)
return false;
/* Check for NullTest qual */
if (IsA(restrictinfo->clause, NullTest))
{
@ -2789,6 +2798,15 @@ bool
restriction_is_always_false(PlannerInfo *root,
RestrictInfo *restrictinfo)
{
/*
* For a clone clause, we don't have a reliable way to determine if the
* input expression of a NullTest is non-nullable: nullingrel bits in
* clone clauses may not reflect reality, so we dare not draw conclusions
* from clones about whether Vars are guaranteed not-null.
*/
if (restrictinfo->has_clone || restrictinfo->is_clone)
return false;
/* Check for NullTest qual */
if (IsA(restrictinfo->clause, NullTest))
{