database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Mark unsafe_tests module as not runnable with installcheck

Browse Source 
This was an omission in the original creation of the module.

Also slightly adjust some wording to avoid a double "is".

Backpatch the non-meson piece of this to release 12, where the module
was introduced.

Discussion: https://postgr.es/m/be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net
This commit is contained in:
Andrew Dunstan
2023-03-12 09:00:32 -04:00
parent bc436e4a91
commit baf7f450db
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/modules/unsafe_tests/Makefile
View File

@@ -2,6 +2,9 @@
REGRESS = rolenames alter_system_table REGRESS = rolenames alter_system_table
# the whole point of these tests is to not run installcheck
NO_INSTALLCHECK = 1
ifdef USE_PGXS ifdef USE_PGXS
PG_CONFIG = pg_config PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs) PGXS := $(shell $(PG_CONFIG) --pgxs)

2
src/test/modules/unsafe_tests/README
View File

@@ -1,6 +1,6 @@
This directory doesn't actually contain any extension module. This directory doesn't actually contain any extension module.
What it is is a home for regression tests that we don't want to run Instead it is a home for regression tests that we don't want to run
during "make installcheck" because they could have side-effects that during "make installcheck" because they could have side-effects that
seem undesirable for a production installation. seem undesirable for a production installation.