database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

Don't allow CREATE TABLE AS to create a column with invalid collation

Browse Source 
It is possible that an expression ends up with a collatable type but
without a collation.  CREATE TABLE AS could then create a table based
on that.  But such a column cannot be dumped with valid SQL syntax, so
we disallow creating such a column.

per test report from Noah Misch
This commit is contained in:
Peter Eisentraut
2011-03-04 23:39:44 +02:00
parent 8d3b421f5f
commit b9cff97fdf
6 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/tablecmds.c
View File

@ -4206,7 +4206,7 @@ ATExecAddColumn(AlteredTableInfo *tab, Relation rel,
typeOid = HeapTupleGetOid(typeTuple);
/* make sure datatype is legal for a column */
CheckAttributeType(colDef->colname, typeOid, false);
CheckAttributeType(colDef->colname, typeOid, collOid, false);
/* construct new attribute's pg_attribute entry */
attribute.attrelid = myrelid;
@ -6515,7 +6515,7 @@ ATPrepAlterColumnType(List **wqueue,
typenameTypeIdModColl(NULL, typeName, &targettype, &targettypmod, &targetcollid);
/* make sure datatype is legal for a column */
CheckAttributeType(colName, targettype, false);
CheckAttributeType(colName, targettype, targetcollid, false);
if (tab->relkind == RELKIND_RELATION)
{