From b93e9a5c94b4c89932a637798bd560971fe790d7 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Thu, 19 Dec 2019 11:19:10 -0500 Subject: [PATCH] revert: Remove meaningless assignments in nbtree code Reverts commit 05684c8255. Reported-by: Tom Lane Discussion: https://postgr.es/m/404.1576770942@sss.pgh.pa.us Backpatch-through: master --- src/backend/access/nbtree/nbtpage.c | 1 + src/backend/access/nbtree/nbtxlog.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c index 4f10ede69d1..e1a111b1ed4 100644 --- a/src/backend/access/nbtree/nbtpage.c +++ b/src/backend/access/nbtree/nbtpage.c @@ -1600,6 +1600,7 @@ _bt_mark_page_halfdead(Relation rel, Buffer leafbuf, BTStack stack) * fail in the field, though. */ page = BufferGetPage(topparent); + opaque = (BTPageOpaque) PageGetSpecialPointer(page); #ifdef USE_ASSERT_CHECKING itemid = PageGetItemId(page, topoff); diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c index 15be50642f1..4325cbee5ba 100644 --- a/src/backend/access/nbtree/nbtxlog.c +++ b/src/backend/access/nbtree/nbtxlog.c @@ -590,6 +590,8 @@ btree_xlog_mark_page_halfdead(uint8 info, XLogReaderState *record) BlockNumber rightsib; page = (Page) BufferGetPage(buffer); + pageop = (BTPageOpaque) PageGetSpecialPointer(page); + poffset = xlrec->poffset; nextoffset = OffsetNumberNext(poffset);