database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-24 00:23:06 +03:00
Code Activity

Avoid looping over all type cache entries in TypeCacheRelCallback()

Browse Source 
Currently, when a single relcache entry gets invalidated,
TypeCacheRelCallback() has to loop over all type cache entries to find
appropriate typentry to invalidate.  Unfortunately, using the syscache here
is impossible, because this callback could be called outside a transaction
and this makes impossible catalog lookups.  This is why present commit
introduces RelIdToTypeIdCacheHash to map relation OID to its composite type
OID.

We are keeping RelIdToTypeIdCacheHash entry while corresponding type cache
entry have something to clean.  Therefore, RelIdToTypeIdCacheHash shouldn't
get bloat in the case of temporary tables flood.

There are many places in lookup_type_cache() where syscache invalidation,
user interruption, or even error could occur.  In order to handle this, we
keep an array of in-progress type cache entries.  In the case of
lookup_type_cache() interruption this array is processed to keep
RelIdToTypeIdCacheHash in a consistent state.

Discussion: https://postgr.es/m/5812a6e5-68ae-4d84-9d85-b443176966a1%40sigaev.ru
Author: Teodor Sigaev
Reviewed-by: Aleksander Alekseev, Tom Lane, Michael Paquier, Roman Zharkov
Reviewed-by: Andrei Lepikhov, Pavel Borisov, Jian He, Alexander Lakhin
Reviewed-by: Artur Zakirov
This commit is contained in:
Alexander Korotkov
2024-10-24 14:35:52 +03:00
parent c1500a1ba7
commit b85a9d046e
11 changed files with 433 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/tools/pgindent/typedefs.list
View File

@@ -2378,6 +2378,7 @@ RelFileLocator
RelFileLocatorBackend
RelFileNumber
RelIdCacheEnt
RelIdToTypeIdCacheEntry
RelInfo
RelInfoArr
RelMapFile