From b787c554c264cbed4de4eff2bb170a5224f0cfa5 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Mon, 25 Apr 2022 15:02:13 -0400 Subject: [PATCH] Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures, so stop doing that. This removes an inconsistency with Windows binaries built with MSVC, which have no such behaviour. Per suggestion from Noah Misch. Backpatch to all live branches. Discussion: https://postgr.es/m/20220423025927.GA1274057@rfd.leadboat.com --- src/common/exec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/common/exec.c b/src/common/exec.c index 95ef13c322d..289b1f26b86 100644 --- a/src/common/exec.c +++ b/src/common/exec.c @@ -33,6 +33,11 @@ #endif #endif +/* Inhibit mingw CRT's auto-globbing of command line arguments */ +#if defined(WIN32) && !defined(_MSC_VER) +extern int _CRT_glob = 0; /* 0 turns off globbing; 1 turns it on */ +#endif + /* * Hacky solution to allow expressing both frontend and backend error reports * in one macro call. First argument of log_error is an errcode() call of