From b64c3bd62ea7064a1a36fbd921e8955fa76faa3e Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Sun, 27 Mar 2022 22:26:40 +0200 Subject: [PATCH] Remove more unused module imports from TAP tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a follow-up to commit 7dac61402 which removed a set of unused modules from the TAP test. The Config references in the pg_ctl and pg_rewind tests were removed in commit 1c6d46293. Fcntl ':mode' and File::stat in the pg_ctl test were added in c37b3d08c which was probably a leftover from an earlier version of the patch, as the function using these was added to another module in that commit. The Config reference in the ldap test was added in ee56c3b21 which in turn use $^O instead of interrogating Config. Author: Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/87lewyqk45.fsf@wibble.ilmari.org --- src/bin/pg_ctl/t/001_start_stop.pl | 3 --- src/bin/pg_rewind/t/RewindTest.pm | 1 - src/test/ldap/t/001_auth.pl | 1 - 3 files changed, 5 deletions(-) diff --git a/src/bin/pg_ctl/t/001_start_stop.pl b/src/bin/pg_ctl/t/001_start_stop.pl index 3b45390ced7..fdffd76d991 100644 --- a/src/bin/pg_ctl/t/001_start_stop.pl +++ b/src/bin/pg_ctl/t/001_start_stop.pl @@ -4,9 +4,6 @@ use strict; use warnings; -use Config; -use Fcntl ':mode'; -use File::stat qw{lstat}; use PostgreSQL::Test::Cluster; use PostgreSQL::Test::Utils; use Test::More; diff --git a/src/bin/pg_rewind/t/RewindTest.pm b/src/bin/pg_rewind/t/RewindTest.pm index 5651602858a..1e34768e270 100644 --- a/src/bin/pg_rewind/t/RewindTest.pm +++ b/src/bin/pg_rewind/t/RewindTest.pm @@ -35,7 +35,6 @@ use strict; use warnings; use Carp; -use Config; use Exporter 'import'; use File::Copy; use File::Path qw(rmtree); diff --git a/src/test/ldap/t/001_auth.pl b/src/test/ldap/t/001_auth.pl index 9f15248935a..b342146e556 100644 --- a/src/test/ldap/t/001_auth.pl +++ b/src/test/ldap/t/001_auth.pl @@ -6,7 +6,6 @@ use warnings; use PostgreSQL::Test::Utils; use PostgreSQL::Test::Cluster; use Test::More; -use Config; my ($slapd, $ldap_bin_dir, $ldap_schema_dir);