database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-28 18:48:04 +03:00
Code Activity

Attached is a patch that fixes 2 test cases of the JDBC test

Browse Source 
suite. This reduces the number of failures from 9 to 7.

Both ConnectionTest and JBuilderTest did not create their own
tables, which caused these test cases to fail with "relation ...
does not exist". It appears these test cases relied on tables
created by the example code elsewhere in the source tree. I've
added the necessary "create table" and "drop table" statements
to the test cases, using the column definitions from the example
code.

While working on that I modified the helper method createTable
in JDBC2Tests.java to take a table parameter, rather than using
table names passed via the properties in build.xml. I'm not sure
what that was good for, and in fact, except for the default
table name "jdbctest", this functionality wasn't used at all.

Ren? Pijlman
This commit is contained in:
Bruce Momjian
2001-09-07 22:17:48 +00:00
parent 7066253ab5
commit b6385efb79
3 changed files with 77 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/interfaces/jdbc/org/postgresql/test/jdbc2/ConnectionTest.java
View File

@@ -10,7 +10,7 @@ import java.sql.*;
*
* PS: Do you know how difficult it is to type on a train? ;-)
*
* $Id: ConnectionTest.java,v 1.2 2001/02/13 16:39:05 peter Exp $
* $Id: ConnectionTest.java,v 1.3 2001/09/07 22:17:48 momjian Exp $
*/
public class ConnectionTest extends TestCase {
@@ -22,6 +22,30 @@ public class ConnectionTest extends TestCase {
super(name);
}
// Set up the fixture for this testcase: the tables for this test.
protected void setUp() throws Exception {
Connection con = JDBC2Tests.openDB();
JDBC2Tests.createTable( con, "test_a",
"imagename name,image oid,id int4" );
JDBC2Tests.createTable( con, "test_c",
"source text,cost money,imageid int4" );
JDBC2Tests.closeDB(con);
}
// Tear down the fixture for this test case.
protected void tearDown() throws Exception {
Connection con = JDBC2Tests.openDB();
Statement stmt = con.createStatement();
stmt.executeUpdate("DROP TABLE test_a");
stmt.executeUpdate("DROP TABLE test_c");
stmt.close();
JDBC2Tests.closeDB(con);
}
/**
* Tests the two forms of createStatement()
*/
@@ -234,4 +258,4 @@ public class ConnectionTest extends TestCase {
assert(ex.getMessage(),false);
}
}
}
}