From b5737efea00717173c0cc889ebd115966abd8c8c Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Tue, 28 Feb 2023 15:47:07 -0500 Subject: [PATCH] Remove unnecessary and problematic collate.windows.win1252 tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some windows instances can't handle setting lc_time to a non BCP 47 locale, and the removed tests in any case don't really make lots of sense here. Juan José Santamaría Flecha Discussion: https://postgr.es/m/237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net --- .../expected/collate.windows.win1252.out | 24 ------------------- .../regress/sql/collate.windows.win1252.sql | 13 ---------- 2 files changed, 37 deletions(-) diff --git a/src/test/regress/expected/collate.windows.win1252.out b/src/test/regress/expected/collate.windows.win1252.out index 4d538f21230..61b421161fa 100644 --- a/src/test/regress/expected/collate.windows.win1252.out +++ b/src/test/regress/expected/collate.windows.win1252.out @@ -361,30 +361,6 @@ SELECT relname FROM pg_class WHERE relname ~* '^abc'; --------- (0 rows) --- to_char -SET lc_time TO 'de_DE'; -SELECT to_char(date '2010-03-01', 'DD TMMON YYYY'); - to_char -------------- - 01 MRZ 2010 -(1 row) - -SELECT to_char(date '2010-03-01', 'DD TMMON YYYY' COLLATE "de_DE"); - to_char -------------- - 01 MRZ 2010 -(1 row) - --- to_date -SELECT to_date('01 MÄR 2010', 'DD TMMON YYYY'); -ERROR: invalid value "MÄR" for "MON" -DETAIL: The given value did not match any of the allowed values for this field. -SELECT to_date('01 Mär 2010', 'DD TMMON YYYY'); -ERROR: invalid value "Mär" for "MON" -DETAIL: The given value did not match any of the allowed values for this field. -SELECT to_date('1234567890ab 2010', 'TMMONTH YYYY'); -- fail -ERROR: invalid value "1234567890ab" for "MONTH" -DETAIL: The given value did not match any of the allowed values for this field. -- backwards parsing CREATE VIEW collview1 AS SELECT * FROM collate_test1 WHERE b COLLATE "C" >= 'bbc'; CREATE VIEW collview2 AS SELECT a, b FROM collate_test1 ORDER BY b COLLATE "C"; diff --git a/src/test/regress/sql/collate.windows.win1252.sql b/src/test/regress/sql/collate.windows.win1252.sql index 64f5ef9b97a..b5c45e18103 100644 --- a/src/test/regress/sql/collate.windows.win1252.sql +++ b/src/test/regress/sql/collate.windows.win1252.sql @@ -150,19 +150,6 @@ FROM collate_test6; SELECT relname FROM pg_class WHERE relname ~* '^abc'; --- to_char - -SET lc_time TO 'de_DE'; -SELECT to_char(date '2010-03-01', 'DD TMMON YYYY'); -SELECT to_char(date '2010-03-01', 'DD TMMON YYYY' COLLATE "de_DE"); - --- to_date - -SELECT to_date('01 MÄR 2010', 'DD TMMON YYYY'); -SELECT to_date('01 Mär 2010', 'DD TMMON YYYY'); -SELECT to_date('1234567890ab 2010', 'TMMONTH YYYY'); -- fail - - -- backwards parsing CREATE VIEW collview1 AS SELECT * FROM collate_test1 WHERE b COLLATE "C" >= 'bbc';