database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-19 17:02:53 +03:00
Code Activity

Fix error reporting for SQL/JSON path type mismatches

Browse Source 
transformJsonFuncExpr() used exprType()/exprLocation() on the
possibly coerced path expression, which could be NULL when
coercion to jsonpath failed, leading to "cache lookup failed
for type 0" errors.

Preserve the original expression node so that type and location
in the "must be of type jsonpath" error are reported correctly.
Add regression tests to cover these cases.

Reported-by: Jian He <jian.universality@gmail.com>
Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://postgr.es/m/CACJufxHunVg81JMuNo8Yvv_hJD0DicgaVN2Wteu8aJbVJPBjZA@mail.gmail.com
Backpatch-through: 17
This commit is contained in:
Amit Langote
2025-11-27 10:40:19 +09:00
parent 2fc5c50622
commit b5511fed50
3 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/backend/parser/parse_expr.c
View File

@@ -4273,6 +4273,9 @@ transformJsonFuncExpr(ParseState *pstate, JsonFuncExpr *func)
{
JsonExpr *jsexpr;
Node *path_spec;
Oid pathspec_type;
int pathspec_loc;
Node *coerced_path_spec;
const char *func_name = NULL;
JsonFormatType default_format;
@@ -4488,17 +4491,21 @@ transformJsonFuncExpr(ParseState *pstate, JsonFuncExpr *func)
jsexpr->format = func->context_item->format;
path_spec = transformExprRecurse(pstate, func->pathspec);
path_spec = coerce_to_target_type(pstate, path_spec, exprType(path_spec),
JSONPATHOID, -1,
COERCION_EXPLICIT, COERCE_IMPLICIT_CAST,
exprLocation(path_spec));
if (path_spec == NULL)
pathspec_type = exprType(path_spec);
pathspec_loc = exprLocation(path_spec);
coerced_path_spec = coerce_to_target_type(pstate, path_spec,
pathspec_type,
JSONPATHOID, -1,
COERCION_EXPLICIT,
COERCE_IMPLICIT_CAST,
pathspec_loc);
if (coerced_path_spec == NULL)
ereport(ERROR,
(errcode(ERRCODE_DATATYPE_MISMATCH),
errmsg("JSON path expression must be of type %s, not of type %s",
"jsonpath", format_type_be(exprType(path_spec))),
parser_errposition(pstate, exprLocation(path_spec))));
jsexpr->path_spec = path_spec;
"jsonpath", format_type_be(pathspec_type)),
parser_errposition(pstate, pathspec_loc)));
jsexpr->path_spec = coerced_path_spec;
/* Transform and coerce the PASSING arguments to jsonb. */
transformJsonPassingArgs(pstate, func_name,