database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Tweak SERIAL column creation to emit a fully qualified sequence name

Browse Source 
as argument for nextval().
This commit is contained in:
Tom Lane
2002-04-02 06:30:34 +00:00
parent 8860110a74
commit b4bedfa956
1 changed files with 27 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/backend/parser/analyze.c
View File

@ -6,7 +6,7 @@
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.225 2002/03/31 06:26:31 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.226 2002/04/02 06:30:34 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -35,6 +35,7 @@
#include "rewrite/rewriteManip.h" #include "rewrite/rewriteManip.h"
#include "utils/builtins.h" #include "utils/builtins.h"
#include "utils/fmgroids.h" #include "utils/fmgroids.h"
#include "utils/lsyscache.h"
#include "utils/relcache.h" #include "utils/relcache.h"
#include "utils/syscache.h" #include "utils/syscache.h"
#ifdef MULTIBYTE #ifdef MULTIBYTE
@ -801,25 +802,43 @@ transformColumnDefinition(ParseState *pstate, CreateStmtContext *cxt,
if (is_serial) if (is_serial)
{ {
char *sname; char *sname;
char *snamespace;
char *qstring; char *qstring;
A_Const *snamenode; A_Const *snamenode;
FuncCall *funccallnode; FuncCall *funccallnode;
CreateSeqStmt *sequence; CreateSeqStmt *seqstmt;
/*
* Determine name and namespace to use for the sequence.
*/
sname = makeObjectName(cxt->relation->relname, column->colname, "seq");
snamespace = get_namespace_name(RangeVarGetCreationNamespace(cxt->relation));
elog(NOTICE, "%s will create implicit sequence '%s' for SERIAL column '%s.%s'",
cxt->stmtType, sname, cxt->relation->relname, column->colname);
/*
* Build a CREATE SEQUENCE command to create the sequence object,
* and add it to the list of things to be done before this
* CREATE/ALTER TABLE.
*/
seqstmt = makeNode(CreateSeqStmt);
seqstmt->sequence = makeRangeVar(snamespace, sname);
seqstmt->options = NIL;
cxt->blist = lappend(cxt->blist, seqstmt);
/* /*
* Create appropriate constraints for SERIAL. We do this in full, * Create appropriate constraints for SERIAL. We do this in full,
* rather than shortcutting, so that we will detect any * rather than shortcutting, so that we will detect any
* conflicting constraints the user wrote (like a different * conflicting constraints the user wrote (like a different
* DEFAULT). * DEFAULT).
*/ *
sname = makeObjectName((cxt->relation)->relname, column->colname, "seq");
/*
* Create an expression tree representing the function call * Create an expression tree representing the function call
* nextval('"sequencename"') * nextval('"sequencename"')
*/ */
qstring = palloc(strlen(sname) + 2 + 1); qstring = palloc(strlen(snamespace) + strlen(sname) + 5 + 1);
sprintf(qstring, "\"%s\"", sname); sprintf(qstring, "\"%s\".\"%s\"", snamespace, sname);
snamenode = makeNode(A_Const); snamenode = makeNode(A_Const);
snamenode->val.type = T_String; snamenode->val.type = T_String;
snamenode->val.val.str = qstring; snamenode->val.val.str = qstring;
@ -845,21 +864,6 @@ transformColumnDefinition(ParseState *pstate, CreateStmtContext *cxt,
constraint = makeNode(Constraint); constraint = makeNode(Constraint);
constraint->contype = CONSTR_NOTNULL; constraint->contype = CONSTR_NOTNULL;
column->constraints = lappend(column->constraints, constraint); column->constraints = lappend(column->constraints, constraint);
/*
* Build a CREATE SEQUENCE command to create the sequence object,
* and add it to the list of things to be done before this
* CREATE/ALTER TABLE.
*/
sequence = makeNode(CreateSeqStmt);
sequence->sequence = copyObject(cxt->relation);
sequence->sequence->relname = pstrdup(sname);
sequence->options = NIL;
elog(NOTICE, "%s will create implicit sequence '%s' for SERIAL column '%s.%s'",
cxt->stmtType, sequence->sequence->relname, (cxt->relation)->relname, column->colname);
cxt->blist = lappend(cxt->blist, sequence);
} }
/* Process column constraints, if any... */ /* Process column constraints, if any... */