From b3558cc96cd9714d879774d13c5bab12ef027864 Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Wed, 9 Feb 2022 18:16:59 -0800 Subject: [PATCH] Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11 and v10. For later branches, this serves as defense in depth. Back-patch to v10 (all supported versions). Discussion: https://postgr.es/m/20220202055556.GB2745933@rfd.leadboat.com --- contrib/amcheck/t/003_cic_2pc.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/amcheck/t/003_cic_2pc.pl b/contrib/amcheck/t/003_cic_2pc.pl index d81734fca78..9b2c92d11a3 100644 --- a/contrib/amcheck/t/003_cic_2pc.pl +++ b/contrib/amcheck/t/003_cic_2pc.pl @@ -11,7 +11,8 @@ use TestLib; use Test::More tests => 5; -local $TODO = 'filesystem bug' if TestLib::has_wal_read_bug; +Test::More->builder->todo_start('filesystem bug') + if TestLib::has_wal_read_bug; my ($node, $result);