database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-17 17:02:08 +03:00
Code Activity

Fix incorrect return value for pg_size_pretty(bigint)

Browse Source 
pg_size_pretty(bigint) would return the value in bytes rather than PB
for the smallest-most bigint value.  This happened due to an incorrect
assumption that the absolute value of -9223372036854775808 could be
stored inside a signed 64-bit type.

Here we fix that by instead storing that value in an unsigned 64-bit type.

This bug does exist in versions prior to 15 but the code there is
sufficiently different and the bug seems sufficiently non-critical that
it does not seem worth risking backpatching further.

Author: Joseph Koshakow <koshy44@gmail.com>
Discussion: https://postgr.es/m/CAAvxfHdTsMZPWEHUrZ=h3cky9Ccc3Mtx2whUHygY+ABP-mCmUw@mail.gmail.com
Backpatch-through: 15
This commit is contained in:
David Rowley
2024-07-28 22:22:52 +12:00
parent 1e666fd7c6
commit b181062aa5
3 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/utils/adt/dbsize.c
View File

@ -575,9 +575,13 @@ pg_size_pretty(PG_FUNCTION_ARGS)
for (unit = size_pretty_units; unit->name != NULL; unit++)
{
uint8 bits;
uint64 abs_size = size < 0 ? 0 - (uint64) size : (uint64) size;
/* use this unit if there are no more units or we're below the limit */
if (unit[1].name == NULL || i64abs(size) < unit->limit)
/*
* Use this unit if there are no more units or the absolute size is
* below the limit for the current unit.
*/
if (unit[1].name == NULL || abs_size < unit->limit)
{
if (unit->round)
size = half_rounded(size);