mirror of
https://github.com/postgres/postgres.git
synced 2025-11-22 12:22:45 +03:00
Preserve index data in pg_statistic across REINDEX CONCURRENTLY
Statistics associated to an index got lost after running REINDEX CONCURRENTLY, while the non-concurrent case preserves these correctly. The concurrent and non-concurrent operations need to be consistent for the end-user, and missing statistics would force to wait for a new analyze to happen, which could take some time depending on the activity of the existing autovacuum workers. This issue is fixed by copying any existing entries in pg_statistic associated to the old index to the new one. Note that this copy is already done with the data of the index in the stats collector. Reported-by: Fabrízio de Royes Mello Author: Michael Paquier, Fabrízio de Royes Mello Reviewed-by: Justin Pryzby Discussion: https://postgr.es/m/CAFcNs+qpFPmiHd1oTXvcPdvAHicJDA9qBUSujgAhUMJyUMb+SA@mail.gmail.com Backpatch-through: 12
This commit is contained in:
@@ -1711,6 +1711,9 @@ index_concurrently_swap(Oid newIndexId, Oid oldIndexId, const char *oldName)
|
||||
}
|
||||
}
|
||||
|
||||
/* Copy data of pg_statistic from the old index to the new one */
|
||||
CopyStatistics(oldIndexId, newIndexId);
|
||||
|
||||
/* Close relations */
|
||||
table_close(pg_class, RowExclusiveLock);
|
||||
table_close(pg_index, RowExclusiveLock);
|
||||
|
||||
Reference in New Issue
Block a user