database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

Explain pruning pgstats accounting subtleties.

Browse Source 
Add a comment explaining why the pgstats accounting used during
opportunistic heap pruning operations (to maintain the current number of
dead tuples in the relation) needs to compensate by subtracting away the
number of new LP_DEAD items.  This is needed so it can avoid completely
forgetting about tuples that become LP_DEAD items during pruning -- they
should still count.

It seems more natural to discuss this issue at the only relevant call
site (opportunistic pruning), since the same issue does not apply to the
only other caller (the VACUUM call site).  Move everything there too.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wzm7f+A6ej650gi_ifTgbhsadVW5cujAL3punpupHff5Yg@mail.gmail.com
This commit is contained in:
Peter Geoghegan
2021-11-12 19:45:58 -08:00
parent 05d8785af2
commit b0f7425ec2
3 changed files with 31 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/access/heap/vacuumlazy.c
View File

@ -1712,6 +1712,7 @@ lazy_scan_prune(LVRelState *vacrel,
new_dead_tuples,
num_tuples,
live_tuples;
int nnewlpdead;
int nfrozen;
OffsetNumber deadoffsets[MaxHeapTuplesPerPage];
xl_heap_freeze_tuple frozen[MaxHeapTuplesPerPage];
@ -1737,7 +1738,7 @@ retry:
* that were deleted from indexes.
*/
tuples_deleted = heap_page_prune(rel, buf, vistest,
InvalidTransactionId, 0, false,
InvalidTransactionId, 0, &nnewlpdead,
&vacrel->offnum);
/*