database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

Prevent 006_transfer_modes.pl from leaving files behind.

Browse Source 
This test was leaving files like delete_old_cluster.{sh,bat} in the
source directory for VPATH and meson builds.  To fix, change the
directory to tmp_check before running the test, as was done in
commits 15b6d21553, 8af917be6b, and c462b054ba.

Oversight in commit af0d4901c1.

Reported-by: Andrew Dunstan <andrew@dunslane.net> (on Discord)
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/Z_RHkG770w3SE0yU%40nathan
This commit is contained in:
Nathan Bossart
2025-04-08 10:57:31 -05:00
parent 88edd661c8
commit b0a4c3e88b
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/bin/pg_upgrade/t/006_transfer_modes.pl
View File

@ -102,6 +102,11 @@ sub test_mode
$new->clean_node(); $new->clean_node();
} }
# Run pg_upgrade in tmp_check to avoid leaving files like
# delete_old_cluster.{sh,bat} in the source directory for VPATH and meson
# builds.
chdir ${PostgreSQL::Test::Utils::tmp_check};
test_mode('--clone'); test_mode('--clone');
test_mode('--copy'); test_mode('--copy');
test_mode('--copy-file-range'); test_mode('--copy-file-range');