database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00
Code Activity

Remove unused xid parameter.

Browse Source 
Commit 6c2003f8a1 removes the use of transaction id's for exporting
snapshots. This commit removes one unused xid parameter left behind in
SnapBuildGetOrBuildSnapshot.

Author: Melih Mutlu
Reviewed-By: Zhang Mingli
Discussion: https://postgr.es/m/CAGPVpCTqZRoDKgCycw+eYi+Gq41rN9pU-gntgTd7wfsNDpPL3Q@mail.gmail.com
This commit is contained in:
Amit Kapila
2022-09-26 08:47:00 +05:30
parent 7d708093b7
commit af51b2f042
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/replication/logical/decode.c
View File

@ -594,7 +594,7 @@ logicalmsg_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
SnapBuildXactNeedsSkip(builder, buf->origptr))) SnapBuildXactNeedsSkip(builder, buf->origptr)))
return; return;
snapshot = SnapBuildGetOrBuildSnapshot(builder, xid); snapshot = SnapBuildGetOrBuildSnapshot(builder);
ReorderBufferQueueMessage(ctx->reorder, xid, snapshot, buf->endptr, ReorderBufferQueueMessage(ctx->reorder, xid, snapshot, buf->endptr,
message->transactional, message->transactional,
message->message, /* first part of message is message->message, /* first part of message is

2
src/backend/replication/logical/snapbuild.c
View File

@ -694,7 +694,7 @@ SnapBuildExportSnapshot(SnapBuild *builder)
* Ensure there is a snapshot and if not build one for current transaction. * Ensure there is a snapshot and if not build one for current transaction.
*/ */
Snapshot Snapshot
SnapBuildGetOrBuildSnapshot(SnapBuild *builder, TransactionId xid) SnapBuildGetOrBuildSnapshot(SnapBuild *builder)
{ {
Assert(builder->state == SNAPBUILD_CONSISTENT); Assert(builder->state == SNAPBUILD_CONSISTENT);

3
src/include/replication/snapbuild.h
View File

@ -73,8 +73,7 @@ extern void SnapBuildClearExportedSnapshot(void);
extern void SnapBuildResetExportedSnapshotState(void); extern void SnapBuildResetExportedSnapshotState(void);
extern SnapBuildState SnapBuildCurrentState(SnapBuild *builder); extern SnapBuildState SnapBuildCurrentState(SnapBuild *builder);
extern Snapshot SnapBuildGetOrBuildSnapshot(SnapBuild *builder, extern Snapshot SnapBuildGetOrBuildSnapshot(SnapBuild *builder);
TransactionId xid);
extern bool SnapBuildXactNeedsSkip(SnapBuild *builder, XLogRecPtr ptr); extern bool SnapBuildXactNeedsSkip(SnapBuild *builder, XLogRecPtr ptr);
extern XLogRecPtr SnapBuildGetTwoPhaseAt(SnapBuild *builder); extern XLogRecPtr SnapBuildGetTwoPhaseAt(SnapBuild *builder);