database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-22 17:42:17 +03:00
Code Activity

Fix error message for COMMENT/SECURITY LABEL ON COLUMN xxx IS 'yyy'

Browse Source 
When the column name is an unqualified name, rather than table.column,
the error message complains about too many dotted names, which is
wrong.  Report by Peter Eisentraut based on examination of the
sepgsql regression test output, but the problem also affects COMMENT.
New wording as suggested by Tom Lane.
This commit is contained in:
Robert Haas
2012-05-22 11:19:33 -04:00
parent 9255d21d2f
commit ae7c8b290f
4 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/catalog/objectaddress.c
View File

@@ -526,6 +526,10 @@ get_object_address_attribute(ObjectType objtype, List *objname,
const char *attname;
/* Extract relation name and open relation. */
if (list_length(objname) < 2)
ereport(ERROR,
(errcode(ERRCODE_SYNTAX_ERROR),
errmsg("column name must be qualified")));
attname = strVal(lfirst(list_tail(objname)));
relname = list_truncate(list_copy(objname), list_length(objname) - 1);
relation = relation_openrv(makeRangeVarFromNameList(relname), lockmode);