From ae667f778d9b7b8ed5a9a8b93abd868690a8ae14 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Tue, 11 Nov 2014 10:25:22 +0200 Subject: [PATCH] Really fix compilation failure on MIPS. I missed an additional colon in previous patch. Oops. to make that mistake less likely in the future, add comments as placeholders for unused inputs and outputs in inline assembly. --- src/include/storage/s_lock.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/include/storage/s_lock.h b/src/include/storage/s_lock.h index 575b9db94e0..7fe6a153b4c 100644 --- a/src/include/storage/s_lock.h +++ b/src/include/storage/s_lock.h @@ -158,7 +158,7 @@ tas(volatile slock_t *lock) " xchgb %0,%1 \n" "1: \n" : "+q"(_res), "+m"(*lock) -: +: /* no inputs */ : "memory", "cc"); return (int) _res; } @@ -225,7 +225,7 @@ tas(volatile slock_t *lock) " lock \n" " xchgb %0,%1 \n" : "+q"(_res), "+m"(*lock) -: +: /* no inputs */ : "memory", "cc"); return (int) _res; } @@ -519,7 +519,7 @@ tas(volatile slock_t *lock) " tas %1 \n" " sne %0 \n" : "=d"(rv), "+m"(*lock) -: +: /* no inputs */ : "memory", "cc"); return rv; } @@ -586,7 +586,7 @@ tas(volatile slock_t *lock) " sync \n" " .set pop " : "=&r" (_res), "=&r" (_tmp), "+R" (*_l) -: +: /* no inputs */ : "memory"); return _res; } @@ -602,7 +602,8 @@ do \ " .set nomacro \n" \ " sync \n" \ " .set pop " \ -: \ +: /* no outputs */ \ +: /* no inputs */ \ : "memory"); \ *((volatile slock_t *) (lock)) = 0; \ } while (0)