database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-19 15:49:24 +03:00
Code Activity

Improve wording in a few comments

Browse Source 
Initially this was to fix the "catched" typo, but I (David) wasn't quite
clear on what the previous comment meant about being "effective".  I
expect this means efficiency, so I've reworded the comment to indicate
that.

While this is only a comment fixup, for the sake of possibly minimizing
possible future backpatching pain, I've opted to backpatch to 18 since
this code is new to that version and the release isn't out the door yet.

Author: Tender Wang <tndrwang@gmail.com>
Discussion: https://postgr.es/m/CAHewXNmSYWPud1sfBvpKbCJeRkWeZYuqatxtV9U9LvAFXBEiBw@mail.gmail.com
Backpatch-through: 18
This commit is contained in:
David Rowley
2025-09-19 23:35:23 +12:00
parent 5b148706c5
commit ac7c8e412c
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/optimizer/path/indxpath.c
View File

@@ -3322,9 +3322,9 @@ match_orclause_to_indexcol(PlannerInfo *root,
/* /*
* Try to convert a list of OR-clauses to a single SAOP expression. Each * Try to convert a list of OR-clauses to a single SAOP expression. Each
* OR entry must be in the form: (indexkey operator constant) or (constant * OR entry must be in the form: (indexkey operator constant) or (constant
* operator indexkey). Operators of all the entries must match. To be * operator indexkey). Operators of all the entries must match. On
* effective, give up on the first non-matching entry. Exit is * discovery of anything unsupported, we give up by breaking out of the
* implemented as a break from the loop, which is catched afterwards. * loop immediately and returning NULL.
*/ */
foreach(lc, orclause->args) foreach(lc, orclause->args)
{ {
@@ -3462,9 +3462,9 @@ match_orclause_to_indexcol(PlannerInfo *root,
} }
/* /*
* Catch the break from the loop above. Normally, a foreach() loop ends * Handle failed conversion from breaking out of the loop because of an
* up with a NULL list cell. A non-NULL list cell indicates a break from * unsupported qual. Free the consts list and return NULL to indicate the
* the foreach() loop. Free the consts list and return NULL then. * conversion failed.
*/ */
if (lc != NULL) if (lc != NULL)
{ {