database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-06 18:42:54 +03:00
Code Activity

Disallow NaN as a value for floating-point GUCs.

Browse Source 
None of the code that uses GUC values is really prepared for them to
hold NaN, but parse_real() didn't have any defense against accepting
such a value.  Treat it the same as a syntax error.

I haven't attempted to analyze the exact consequences of setting any
of the float GUCs to NaN, but since they're quite unlikely to be good,
this seems like a back-patchable bug fix.

Note: we don't need an explicit test for +-Infinity because those will
be rejected by existing range checks.  I added a regression test for
that in HEAD, but not older branches because the spelling of the value
in the error message will be platform-dependent in branches where we
don't always use port/snprintf.c.

Discussion: https://postgr.es/m/1798.1552165479@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2019-03-10 12:58:51 -04:00
parent 203749a8a6
commit ac75959cdc
3 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/regress/expected/guc.out
View File

@@ -506,6 +506,13 @@ SELECT '2006-08-13 12:34:56'::timestamptz;
Sun Aug 13 12:34:56 2006 PDT
(1 row)
-- Test some simple error cases
SET seq_page_cost TO 'NaN';
ERROR: parameter "seq_page_cost" requires a numeric value
SET vacuum_cost_delay TO '10s';
ERROR: 10000 is outside the valid range for parameter "vacuum_cost_delay" (0 .. 100)
SET geqo_selection_bias TO '-infinity';
ERROR: -Infinity is outside the valid range for parameter "geqo_selection_bias" (1.5 .. 2)
--
-- Test DISCARD TEMP
--

5
src/test/regress/sql/guc.sql
View File

@@ -144,6 +144,11 @@ RESET datestyle;
SHOW datestyle;
SELECT '2006-08-13 12:34:56'::timestamptz;
-- Test some simple error cases
SET seq_page_cost TO 'NaN';
SET vacuum_cost_delay TO '10s';
SET geqo_selection_bias TO '-infinity';
--
-- Test DISCARD TEMP
--