1
0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00

Disallow NaN as a value for floating-point GUCs.

None of the code that uses GUC values is really prepared for them to
hold NaN, but parse_real() didn't have any defense against accepting
such a value.  Treat it the same as a syntax error.

I haven't attempted to analyze the exact consequences of setting any
of the float GUCs to NaN, but since they're quite unlikely to be good,
this seems like a back-patchable bug fix.

Note: we don't need an explicit test for +-Infinity because those will
be rejected by existing range checks.  I added a regression test for
that in HEAD, but not older branches because the spelling of the value
in the error message will be platform-dependent in branches where we
don't always use port/snprintf.c.

Discussion: https://postgr.es/m/1798.1552165479@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2019-03-10 12:58:51 -04:00
parent 203749a8a6
commit ac75959cdc
3 changed files with 16 additions and 0 deletions

View File

@ -6149,6 +6149,10 @@ parse_real(const char *value, double *result)
if (endptr == value || errno == ERANGE)
return false;
/* reject NaN (infinities will fail range checks later) */
if (isnan(val))
return false;
/* allow whitespace after number */
while (isspace((unsigned char) *endptr))
endptr++;