database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Fix misuse of TextDatumGetCString().

Browse Source 
"TextDatumGetCString(PG_GETARG_TEXT_P(x))" is formally wrong: a text*
is not a Datum.  Although this coding will accidentally fail to fail on
all known platforms, it risks leaking memory if a detoast step is needed,
unlike "TextDatumGetCString(PG_GETARG_DATUM(x))" which is what's used
elsewhere.  Make pg_get_object_address() fall in line with other uses.

Noted while reviewing two-arg current_setting() patch.
This commit is contained in:
Tom Lane
2015-07-02 17:02:08 -04:00
parent 10fb48d66d
commit ac50f84866
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/catalog/objectaddress.c
View File

@ -1831,7 +1831,7 @@ textarray_to_strvaluelist(ArrayType *arr)
Datum Datum
pg_get_object_address(PG_FUNCTION_ARGS) pg_get_object_address(PG_FUNCTION_ARGS)
{ {
char *ttype = TextDatumGetCString(PG_GETARG_TEXT_P(0)); char *ttype = TextDatumGetCString(PG_GETARG_DATUM(0));
ArrayType *namearr = PG_GETARG_ARRAYTYPE_P(1); ArrayType *namearr = PG_GETARG_ARRAYTYPE_P(1);
ArrayType *argsarr = PG_GETARG_ARRAYTYPE_P(2); ArrayType *argsarr = PG_GETARG_ARRAYTYPE_P(2);
int itype; int itype;