database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Fix incorrect handling of polymorphic aggregates used as window functions.

Browse Source 
The transfunction was told that its first argument and result were
of the window function output type, not the aggregate state type.
This'd only matter if the transfunction consults get_fn_expr_argtype,
which typically only polymorphic functions would do.

Although we have several regression tests around polymorphic aggs,
none of them detected this mistake --- in fact, they still didn't
fail when I injected the same mistake into nodeAgg.c.  So add some
more tests covering both plain agg and window-function-agg cases.

Per report from Sebastian Luque.  Back-patch to 9.6 where the error
was introduced (by sloppy refactoring in commit 804163bc2, looks like).

Report: <87int2qkat.fsf@gmail.com>
This commit is contained in:
Tom Lane
2016-10-09 12:49:37 -04:00
parent e55a946a81
commit ac4a9d92fc
3 changed files with 78 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/executor/nodeWindowAgg.c
View File

@ -2218,7 +2218,7 @@ initialize_peragg(WindowAggState *winstate, WindowFunc *wfunc,
numArguments,
0, /* no ordered-set window functions yet */
false, /* no variadic window functions yet */
wfunc->wintype,
aggtranstype,
wfunc->inputcollid,
transfn_oid,
invtransfn_oid,