From ab1d9f066aee4f9b81abde6136771debe0191ae8 Mon Sep 17 00:00:00 2001
From: Michael Paquier <michael@paquier.xyz>
Date: Thu, 28 Feb 2019 11:02:23 +0900
Subject: [PATCH] Improve documentation of data_sync_retry
Reflecting an updated parameter value requires a server restart, which
was not mentioned in the documentation and in postgresql.conf.sample.
Reported-by: Thomas Poty
Discussion: https://postgr.es/m/15659-0cd812f13027a2d8@postgresql.org
---
doc/src/sgml/config.sgml | 3 ++-
src/backend/utils/misc/postgresql.conf.sample | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index cd868e36d21..ef0787a5a13 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7783,7 +7783,8 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir'
<para>
When set to false, which is the default, <productname>PostgreSQL</productname>
will raise a PANIC-level error on failure to flush modified data files
- to the filesystem. This causes the database server to crash.
+ to the filesystem. This causes the database server to crash. This
+ parameter can only be set at server start.
</para>
<para>
On some operating systems, the status of data in the kernel's page
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 3e68afd2750..160011f4de3 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -635,7 +635,9 @@
#exit_on_error = off # terminate session on any error?
#restart_after_crash = on # reinitialize after backend crash?
-#data_sync_retry = off # retry or panic on failure to fsync data?
+#data_sync_retry = off # retry or panic on failure to fsync
+ # data?
+ # (change requires restart)
#------------------------------------------------------------------------------