database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-21 12:05:57 +03:00
Code

Set LSN for wbuf in _hash_freeovflpage() iff wbuf is modified.

Browse Source 
Commit 861f86beea used REGBUF_NO_CHANGE at one of the places in the hash
index to register the clean buffers but forgot to avoid setting LSN in
that case.

Reported-by: Michael Paquier
Author: Kuroda Hayato
Reviewed-by: Amit Kapila, Michael Paquier
Discussion: https://postgr.es/m/ZbyVVG_7eW3YD5-A@paquier.xyz
This commit is contained in:
Amit Kapila 2024-02-07 11:10:12 +05:30
parent 22f7e61a63
commit aa5edbe379
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/backend/access/hash/hashovfl.c
View File

@ -647,6 +647,7 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
xl_hash_squeeze_page xlrec; xl_hash_squeeze_page xlrec;
XLogRecPtr recptr; XLogRecPtr recptr;
int i; int i;
bool mod_wbuf = false;
xlrec.prevblkno = prevblkno; xlrec.prevblkno = prevblkno;
xlrec.nextblkno = nextblkno; xlrec.nextblkno = nextblkno;
@ -671,6 +672,10 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
if (xlrec.ntups > 0) if (xlrec.ntups > 0)
{ {
XLogRegisterBuffer(1, wbuf, REGBUF_STANDARD); XLogRegisterBuffer(1, wbuf, REGBUF_STANDARD);
/* Remember that wbuf is modified. */
mod_wbuf = true;
XLogRegisterBufData(1, (char *) itup_offsets, XLogRegisterBufData(1, (char *) itup_offsets,
nitups * sizeof(OffsetNumber)); nitups * sizeof(OffsetNumber));
for (i = 0; i < nitups; i++) for (i = 0; i < nitups; i++)
@ -690,7 +695,14 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
wbuf_flags = REGBUF_STANDARD; wbuf_flags = REGBUF_STANDARD;
if (!xlrec.is_prev_bucket_same_wrt) if (!xlrec.is_prev_bucket_same_wrt)
{
wbuf_flags |= REGBUF_NO_CHANGE; wbuf_flags |= REGBUF_NO_CHANGE;
}
else
{
/* Remember that wbuf is modified. */
mod_wbuf = true;
}
XLogRegisterBuffer(1, wbuf, wbuf_flags); XLogRegisterBuffer(1, wbuf, wbuf_flags);
} }
@ -719,7 +731,10 @@ _hash_freeovflpage(Relation rel, Buffer bucketbuf, Buffer ovflbuf,
recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_SQUEEZE_PAGE); recptr = XLogInsert(RM_HASH_ID, XLOG_HASH_SQUEEZE_PAGE);
PageSetLSN(BufferGetPage(wbuf), recptr); /* Set LSN iff wbuf is modified. */
if (mod_wbuf)
PageSetLSN(BufferGetPage(wbuf), recptr);
PageSetLSN(BufferGetPage(ovflbuf), recptr); PageSetLSN(BufferGetPage(ovflbuf), recptr);
if (BufferIsValid(prevbuf) && !xlrec.is_prev_bucket_same_wrt) if (BufferIsValid(prevbuf) && !xlrec.is_prev_bucket_same_wrt)