database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-04 20:11:56 +03:00
Code Activity

formatting.c cleanup: Change fill_str() return type to void

Browse Source 
The return value is not used anywhere.

In passing, add a comment explaining the function's arguments.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/6dd9d208-a3ed-49b5-b03d-8617261da973%40eisentraut.org
This commit is contained in:
Peter Eisentraut
2025-10-31 09:53:01 +01:00
parent da2052ab9a
commit aa4535307e
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/utils/adt/formatting.c
View File

@@ -1113,7 +1113,7 @@ static bool from_char_seq_search(int *dest, const char **src,
static bool do_to_timestamp(const text *date_txt, const text *fmt, Oid collid, bool std, static bool do_to_timestamp(const text *date_txt, const text *fmt, Oid collid, bool std,
struct pg_tm *tm, fsec_t *fsec, struct fmt_tz *tz, struct pg_tm *tm, fsec_t *fsec, struct fmt_tz *tz,
int *fprec, uint32 *flags, Node *escontext); int *fprec, uint32 *flags, Node *escontext);
static char *fill_str(char *str, int c, int max); static void fill_str(char *str, int c, int max);
static FormatNode *NUM_cache(int len, NUMDesc *Num, const text *pars_str, bool *shouldFree); static FormatNode *NUM_cache(int len, NUMDesc *Num, const text *pars_str, bool *shouldFree);
static char *int_to_roman(int number); static char *int_to_roman(int number);
static int roman_to_int(NUMProc *Np, size_t input_len); static int roman_to_int(NUMProc *Np, size_t input_len);
@@ -4824,12 +4824,15 @@ fail:
*********************************************************************/ *********************************************************************/
static char * /*
* Fill str with character c max times, and add terminating \0. (So max+1
* bytes are written altogether!)
*/
static void
fill_str(char *str, int c, int max) fill_str(char *str, int c, int max)
{ {
memset(str, c, max); memset(str, c, max);
str[max] = '\0'; str[max] = '\0';
return str;
} }
/* This works the same as DCH_prevent_counter_overflow */ /* This works the same as DCH_prevent_counter_overflow */