database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-25 01:02:05 +03:00
Code Activity

Silence unused variable compiler warning

Browse Source 
Fallout from fcec6caafa: mark a variable in
set_tablefunc_size_estimates as used for asserts only.

Also, the planner_rte_fetch() call is pointless with assertions
disabled, so enclose it in a USE_ASSERT_CHECKING #ifdef; fix the same
problem in set_subquery_size_estimates().

First problem noted by David Rowley, whose compiler is noisier than mine
in this regard.
This commit is contained in:
Alvaro Herrera
2017-03-13 18:54:35 -03:00
parent 895e36bb3f
commit a9c074ba7e
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/optimizer/path/costsize.c
View File

@ -4458,8 +4458,10 @@ set_subquery_size_estimates(PlannerInfo *root, RelOptInfo *rel)
/* Should only be applied to base relations that are subqueries */ /* Should only be applied to base relations that are subqueries */
Assert(rel->relid > 0); Assert(rel->relid > 0);
#ifdef USE_ASSERT_CHECKING
rte = planner_rt_fetch(rel->relid, root); rte = planner_rt_fetch(rel->relid, root);
Assert(rte->rtekind == RTE_SUBQUERY); Assert(rte->rtekind == RTE_SUBQUERY);
#endif
/* /*
* Copy raw number of output rows from subquery. All of its paths should * Copy raw number of output rows from subquery. All of its paths should
@ -4571,12 +4573,14 @@ set_function_size_estimates(PlannerInfo *root, RelOptInfo *rel)
void void
set_tablefunc_size_estimates(PlannerInfo *root, RelOptInfo *rel) set_tablefunc_size_estimates(PlannerInfo *root, RelOptInfo *rel)
{ {
RangeTblEntry *rte; RangeTblEntry *rte PG_USED_FOR_ASSERTS_ONLY;
/* Should only be applied to base relations that are functions */ /* Should only be applied to base relations that are functions */
Assert(rel->relid > 0); Assert(rel->relid > 0);
#ifdef USE_ASSERT_CHECKING
rte = planner_rt_fetch(rel->relid, root); rte = planner_rt_fetch(rel->relid, root);
Assert(rte->rtekind == RTE_TABLEFUNC); Assert(rte->rtekind == RTE_TABLEFUNC);
#endif
rel->tuples = 100; rel->tuples = 100;