database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-26 01:22:12 +03:00
Code Activity

Fix unportable shell-script syntax in pg_upgrade's test.sh.

Browse Source 
I discovered the hard way that on some old shells, the locution
    FOO=""   unset FOO
does not behave the same as
    FOO="";  unset FOO
and in fact leaves FOO set to an empty string.  test.sh was inconsistently
spelling it different ways on adjacent lines.

This got broken relatively recently, in commit c737a2e56, so the lack of
field reports to date doesn't represent a lot of evidence that the problem
is rare.
This commit is contained in:
Tom Lane
2014-03-16 21:55:06 -04:00
parent 37e5b3d9bd
commit a98ad4fabc
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/pg_upgrade/test.sh
View File

@ -83,10 +83,10 @@ mkdir "$logdir"
PGDATABASE=""; unset PGDATABASE PGDATABASE=""; unset PGDATABASE
PGUSER=""; unset PGUSER PGUSER=""; unset PGUSER
PGSERVICE=""; unset PGSERVICE PGSERVICE=""; unset PGSERVICE
PGSSLMODE="" unset PGSSLMODE PGSSLMODE=""; unset PGSSLMODE
PGREQUIRESSL=""; unset PGREQUIRESSL PGREQUIRESSL=""; unset PGREQUIRESSL
PGCONNECT_TIMEOUT=""; unset PGCONNECT_TIMEOUT PGCONNECT_TIMEOUT=""; unset PGCONNECT_TIMEOUT
PGHOST="" unset PGHOST PGHOST=""; unset PGHOST
PGHOSTADDR=""; unset PGHOSTADDR PGHOSTADDR=""; unset PGHOSTADDR
# Select a non-conflicting port number, similarly to pg_regress.c # Select a non-conflicting port number, similarly to pg_regress.c