database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-27 23:21:58 +03:00
Code Activity

Remove xmlCleanupParser calls from contrib/xml2.

Browse Source 
These are unnecessary and probably dangerous.  I don't see any immediate
risk situations in the core XML support or contrib/xml2 itself, but there
could be issues with external uses of libxml2, and in any case it's an
accident waiting to happen.
This commit is contained in:
Tom Lane
2010-03-01 05:17:01 +00:00
parent 94152f93f5
commit a8ab473383
2 changed files with 4 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/xml2/xslt_proc.c
View File

@ -80,7 +80,6 @@ xslt_process(PG_FUNCTION_ARGS)
if (doctree == NULL)
{
xmlCleanupParser();
elog_error("Error parsing XML document", false);
PG_RETURN_NULL();
@ -94,7 +93,6 @@ xslt_process(PG_FUNCTION_ARGS)
if (ssdoc == NULL)
{
xmlFreeDoc(doctree);
xmlCleanupParser();
elog_error("Error parsing stylesheet as XML document", false);
PG_RETURN_NULL();
}
@ -109,7 +107,6 @@ xslt_process(PG_FUNCTION_ARGS)
{
xmlFreeDoc(doctree);
xsltCleanupGlobals();
xmlCleanupParser();
elog_error("Failed to parse stylesheet", false);
PG_RETURN_NULL();
}
@ -122,7 +119,6 @@ xslt_process(PG_FUNCTION_ARGS)
xmlFreeDoc(doctree);
xsltCleanupGlobals();
xmlCleanupParser();
if (resstat < 0)
PG_RETURN_NULL();