mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Refactor the executor's API to support data-modifying CTEs better.
The originally committed patch for modifying CTEs didn't interact well with EXPLAIN, as noted by myself, and also had corner-case problems with triggers, as noted by Dean Rasheed. Those problems show it is really not practical for ExecutorEnd to call any user-defined code; so split the cleanup duties out into a new function ExecutorFinish, which must be called between the last ExecutorRun call and ExecutorEnd. Some Asserts have been added to these functions to help verify correct usage. It is no longer necessary for callers of the executor to call AfterTriggerBeginQuery/AfterTriggerEndQuery for themselves, as this is now done by ExecutorStart/ExecutorFinish respectively. If you really need to suppress that and do it for yourself, pass EXEC_FLAG_SKIP_TRIGGERS to ExecutorStart. Also, refactor portal commit processing to allow for the possibility that PortalDrop will invoke user-defined code. I think this is not actually necessary just yet, since the portal-execution-strategy logic forces any non-pure-SELECT query to be run to completion before we will consider committing. But it seems like good future-proofing.
This commit is contained in:
@ -3676,9 +3676,9 @@ AfterTriggerBeginQuery(void)
|
||||
* we invoke all AFTER IMMEDIATE trigger events queued by the query, and
|
||||
* transfer deferred trigger events to the global deferred-trigger list.
|
||||
*
|
||||
* Note that this should be called just BEFORE closing down the executor
|
||||
* Note that this must be called BEFORE closing down the executor
|
||||
* with ExecutorEnd, because we make use of the EState's info about
|
||||
* target relations.
|
||||
* target relations. Normally it is called from ExecutorFinish.
|
||||
* ----------
|
||||
*/
|
||||
void
|
||||
|
Reference in New Issue
Block a user