database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

> I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the

Browse Source 
> moment, but they used to be used; I think the correct response is to
> put back the missing counter increments, not rip out the counters.

Ok, fair enough. It's worth noting that they've been broken for a
while -- for example, the HashJoin counter increments were broken when
you comitted r1.20 of executor/nodeHashJoin.c in May of '99.

I've attached a revised patch that doesn't remove the counters (but
doesn't increment them either: I'm not sure of all the places where
the counter should be incremented).

Neil Conway
This commit is contained in:
Bruce Momjian
2002-09-20 03:45:08 +00:00
parent 708a000efe
commit a834cbe1e9
2 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/tcop/postgres.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.292 2002/09/16 01:24:41 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.293 2002/09/20 03:45:08 momjian Exp $
*
* NOTES
* this is the "main" module of the postgres backend and
@ -486,7 +486,7 @@ pg_plan_query(Query *querytree)
if (Show_planner_stats)
ResetUsage();
/* call that optimizer */
/* call the optimizer */
plan = planner(querytree);
if (Show_planner_stats)
@ -1691,7 +1691,7 @@ PostgresMain(int argc, char *argv[], const char *username)
if (!IsUnderPostmaster)
{
puts("\nPOSTGRES backend interactive interface ");
puts("$Revision: 1.292 $ $Date: 2002/09/16 01:24:41 $\n");
puts("$Revision: 1.293 $ $Date: 2002/09/20 03:45:08 $\n");
}
/*
@ -2080,7 +2080,7 @@ ShowUsage(const char *title)
#endif /* HAVE_GETRUSAGE */
bufusage = ShowBufferUsage();
appendStringInfo(&str, "! postgres usage stats:\n%s", bufusage);
appendStringInfo(&str, "! buffer usage stats:\n%s", bufusage);
pfree(bufusage);
/* remove trailing newline */