From a7c63e486050636925f81123b1427f1cb49644a2 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Fri, 16 Jan 2026 12:12:26 +0900 Subject: [PATCH] Fix stability issue with new TAP test of pg_createsubscriber The test introduced in 639352d904c8 has added a direct pg_ctl command to start a node, a method that is incompatible with the teardown() routine used at the end of the test as the PID saved in the Cluster object would prevent the node to be shut down. This can ultimately prevent the test to perform its cleanup, failing on timeout. Like pg_ctl's 001_start_stop or ssl_passphrase_callback's 001_testfunc, this commit changes the test so a direct pg_ctl command is used to stop the rogue node. That should be hopefully enough to cool down the buildfarm. Per report from buildfarm member fairywren, which is the only animal that is showing this issue. Author: Hayato Kuroda Discussion: https://postgr.es/m/TY7PR01MB1455452AE9053DD2B77B74FEAF58CA@TY7PR01MB14554.jpnprd01.prod.outlook.com --- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl index e1de946488e..0c27fca7bb7 100644 --- a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl +++ b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl @@ -624,11 +624,15 @@ command_ok( ], "node K has started"); +# Note that this uses a direct pg_ctl command rather than a teardown(), +# because $node->stop() would not work due to the node's postmaster PID +# not being tracked, something that is set within $node->start(). +system_log('pg_ctl', 'stop', '--pgdata', $node_k->data_dir); + # clean up $node_p->teardown_node; $node_s->teardown_node; $node_t->teardown_node; $node_f->teardown_node; -$node_k->teardown_node; done_testing();