database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-29 22:49:41 +03:00
Code Activity

Backpatch dbmirror fix for escape handling.

Browse Source 
> Upstream confirmed my reply in the last mail in [1]: the complete
> escaping logic in DBMirror.pl is seriously screwew.
>
> [1] http://archives.postgresql.org/pgsql-bugs/2006-06/msg00065.php

I finally found some time to debug this, and I think I found a better
patch than the one you proposed. Mine is still hackish and is still a
workaround around a proper quoting solution, but at least it repairs
the parsing without introducing the \' quoting again.

I consider this a band-aid patch to fix the recent security update.
PostgreSQL gurus, would you consider applying this until a better
solution is found for DBMirror.pl?

Olivier, can you please confirm that the patch works for you, too?

Backpatched to 8.0.X.

Martin Pitt
This commit is contained in:
Bruce Momjian
2006-07-06 01:57:25 +00:00
parent 4f4d62a5b5
commit a7aa0b8189
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/dbmirror/DBMirror.pl
View File

@@ -33,7 +33,7 @@
# #
# #
############################################################################## ##############################################################################
# $PostgreSQL: pgsql/contrib/dbmirror/DBMirror.pl,v 1.11 2006/05/19 02:38:47 momjian Exp $ # $PostgreSQL: pgsql/contrib/dbmirror/DBMirror.pl,v 1.12 2006/07/06 01:57:25 momjian Exp $
# #
############################################################################## ##############################################################################
@@ -907,7 +907,7 @@ sub extractData($$) {
$matchString = $1; $matchString = $1;
$value .= substr $matchString,0,length($matchString)-1; $value .= substr $matchString,0,length($matchString)-1;
if($matchString =~ m/(\'$)/s) { if($matchString =~ m/(\'$)/s and (substr $dataField,length($matchString),1) ne "'") {
# $1 runs to the end of the field value. # $1 runs to the end of the field value.
$dataField = substr $dataField,length($matchString)+1; $dataField = substr $dataField,length($matchString)+1;
last; last;