database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Fix crash in multi-insert COPY

Browse Source 
A bug introduced in 0d5f05cde0
considered the *previous* partition's triggers when deciding whether
multi-insert can be used.  Rearrange the code so that the current
partition is considered.

Author: Ashutosh Sharma <ashu.coek88@gmail.com>
This commit is contained in:
Peter Eisentraut
2018-10-17 20:31:20 +02:00
parent d8cc1616b5
commit a7a1b44516
3 changed files with 52 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/backend/commands/copy.c
View File

@ -2783,21 +2783,7 @@ CopyFrom(CopyState cstate)
lastPartitionSampleLineNo = cstate->cur_lineno;
nPartitionChanges = 0;
}
/*
* Tests have shown that using multi-inserts when the
* partition changes on every tuple slightly decreases the
* performance, however, there are benefits even when only
* some batches have just 2 tuples, so let's enable
* multi-inserts even when the average is quite low.
*/
leafpart_use_multi_insert = avgTuplesPerPartChange >= 1.3 &&
!has_before_insert_row_trig &&
!has_instead_insert_row_trig &&
resultRelInfo->ri_FdwRoutine == NULL;
}
else
leafpart_use_multi_insert = false;
/*
* Overwrite resultRelInfo with the corresponding partition's
@ -2821,6 +2807,19 @@ CopyFrom(CopyState cstate)
has_instead_insert_row_trig = (resultRelInfo->ri_TrigDesc &&
resultRelInfo->ri_TrigDesc->trig_insert_instead_row);
/*
* Tests have shown that using multi-inserts when the
* partition changes on every tuple slightly decreases the
* performance, however, there are benefits even when only
* some batches have just 2 tuples, so let's enable
* multi-inserts even when the average is quite low.
*/
leafpart_use_multi_insert = insertMethod == CIM_MULTI_CONDITIONAL &&
avgTuplesPerPartChange >= 1.3 &&
!has_before_insert_row_trig &&
!has_instead_insert_row_trig &&
resultRelInfo->ri_FdwRoutine == NULL;
/*
* We'd better make the bulk insert mechanism gets a new
* buffer when the partition being inserted into changes.