database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-16 17:07:43 +03:00
Code Activity

Tidy-up unneeded NULL parameter checks from SQL function

Browse Source 
This function is marked as strict, so we can safely remove the checks
checking for NULL input parameters.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAApHDvqiN0+mbooUOSCDALc=GoM8DmTbCdvwnCwak6Wb2O1ZJA@mail.gmail.com
This commit is contained in:
David Rowley
2025-10-03 23:04:37 +13:00
parent 54ab748651
commit a69b55cd47
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/test/modules/test_bitmapset/test_bitmapset.c
View File

@@ -587,7 +587,7 @@ test_bitmap_match(PG_FUNCTION_ARGS)
* "min_value" is the minimal value used for the members, that will stand * "min_value" is the minimal value used for the members, that will stand
* up to a range of "max_range". "num_ops" defines the number of time each * up to a range of "max_range". "num_ops" defines the number of time each
* operation is done. "seed" is a random seed used to calculate the member * operation is done. "seed" is a random seed used to calculate the member
* values. * values. When "seed" is <= 0, a random seed will be chosen automatically.
* *
* The return value is the number of times all operations have been executed. * The return value is the number of times all operations have been executed.
*/ */
@@ -600,25 +600,20 @@ test_random_operations(PG_FUNCTION_ARGS)
Bitmapset *result = NULL; Bitmapset *result = NULL;
pg_prng_state state; pg_prng_state state;
uint64 seed = GetCurrentTimestamp(); uint64 seed = GetCurrentTimestamp();
int num_ops = 5000; int num_ops;
int total_ops = 0; int max_range;
int max_range = 2000; int min_value;
int min_value = 0;
int member; int member;
int *members; int *members;
int num_members = 0; int num_members = 0;
int total_ops = 0;
if (!PG_ARGISNULL(0) && PG_GETARG_INT32(0) > 0) if (PG_GETARG_INT32(0) > 0)
seed = PG_GETARG_INT32(0); seed = PG_GETARG_INT32(0);
if (!PG_ARGISNULL(1)) num_ops = PG_GETARG_INT32(1);
num_ops = PG_GETARG_INT32(1); max_range = PG_GETARG_INT32(2);
min_value = PG_GETARG_INT32(3);
if (!PG_ARGISNULL(2))
max_range = PG_GETARG_INT32(2);
if (!PG_ARGISNULL(3))
min_value = PG_GETARG_INT32(3);
pg_prng_seed(&state, seed); pg_prng_seed(&state, seed);
members = palloc(sizeof(int) * num_ops); members = palloc(sizeof(int) * num_ops);