database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-29 10:41:53 +03:00
Code Activity

Fix inconsistent equalfuncs.c behavior for FuncCall.funcformat.

Browse Source 
Other equalfuncs.c checks on CoercionForm fields use
COMPARE_COERCIONFORM_FIELD (which makes them no-ops),
but commit 40c24bfef neglected to make _equalFuncCall
do likewise.  Fix that.

This is only strictly correct if FuncCall.funcformat has
no semantic effect, instead just determining ruleutils.c
display formatting.  40c24bfef added a couple of checks
in parse analysis that could break that rule; but on closer
inspection, they're redundant, so just take them out again.

Per report from Noah Misch.

Discussion: https://postgr.es/m/20210606063331.GC297923@rfd.leadboat.com
This commit is contained in:
Tom Lane
2021-06-06 15:46:58 -04:00
parent d57ecebd12
commit a65e9f3f14
3 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/nodes/equalfuncs.c
View File

@ -2420,7 +2420,7 @@ _equalFuncCall(const FuncCall *a, const FuncCall *b)
COMPARE_SCALAR_FIELD(agg_star); COMPARE_SCALAR_FIELD(agg_star);
COMPARE_SCALAR_FIELD(agg_distinct); COMPARE_SCALAR_FIELD(agg_distinct);
COMPARE_SCALAR_FIELD(func_variadic); COMPARE_SCALAR_FIELD(func_variadic);
COMPARE_SCALAR_FIELD(funcformat); COMPARE_COERCIONFORM_FIELD(funcformat);
COMPARE_LOCATION_FIELD(location); COMPARE_LOCATION_FIELD(location);
return true; return true;

1
src/backend/parser/parse_clause.c
View File

@ -543,7 +543,6 @@ transformRangeFunction(ParseState *pstate, RangeFunction *r)
!fc->agg_star && !fc->agg_star &&
!fc->agg_distinct && !fc->agg_distinct &&
!fc->func_variadic && !fc->func_variadic &&
fc->funcformat == COERCE_EXPLICIT_CALL &&
coldeflist == NIL) coldeflist == NIL)
{ {
ListCell *lc; ListCell *lc;

1
src/backend/parser/parse_func.c
View File

@ -222,7 +222,6 @@ ParseFuncOrColumn(ParseState *pstate, List *funcname, List *fargs,
agg_order == NIL && agg_filter == NULL && agg_order == NIL && agg_filter == NULL &&
!agg_star && !agg_distinct && over == NULL && !agg_star && !agg_distinct && over == NULL &&
!func_variadic && argnames == NIL && !func_variadic && argnames == NIL &&
funcformat == COERCE_EXPLICIT_CALL &&
list_length(funcname) == 1 && list_length(funcname) == 1 &&
(actual_arg_types[0] == RECORDOID || (actual_arg_types[0] == RECORDOID ||
ISCOMPLEX(actual_arg_types[0]))); ISCOMPLEX(actual_arg_types[0])));