database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-19 15:49:24 +03:00
Code Activity

Improve TAP tests by replacing ok() with better Test::More functions

Browse Source 
Transpose the changes made by commit fabb33b35 in 002_pg_dump.pl
into its recently-created clone 006_pg_dump_compress.pl.
This commit is contained in:
Tom Lane
2025-10-17 11:25:53 -04:00
parent 7d129ba54e
commit a6113dc1da
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/pg_dump/t/006_pg_dump_compress.pl
View File

@@ -612,7 +612,8 @@ foreach my $run (sort keys %pgdump_runs)
if (($tests{$test}->{like}->{$test_key} || $tests{$test}->{all_runs}) if (($tests{$test}->{like}->{$test_key} || $tests{$test}->{all_runs})
&& !defined($tests{$test}->{unlike}->{$test_key})) && !defined($tests{$test}->{unlike}->{$test_key}))
{ {
if (!ok($output_file =~ $tests{$test}->{regexp}, if (!like(
$output_file, $tests{$test}->{regexp},
"$run: should dump $test")) "$run: should dump $test"))
{ {
diag("Review $run results in $tempdir"); diag("Review $run results in $tempdir");
@@ -620,7 +621,8 @@ foreach my $run (sort keys %pgdump_runs)
} }
else else
{ {
if (!ok($output_file !~ $tests{$test}->{regexp}, if (!unlike(
$output_file, $tests{$test}->{regexp},
"$run: should not dump $test")) "$run: should not dump $test"))
{ {
diag("Review $run results in $tempdir"); diag("Review $run results in $tempdir");