database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-25 13:17:41 +03:00
Code Activity

Yet more elimination of dead stores and useless initializations.

Browse Source 
I'm not sure what tool Ranier was using, but the ones I contributed
were found by using a newer version of scan-build than I tried before.

Ranier Vilela and Tom Lane

Discussion: https://postgr.es/m/CAEudQAo1+AcGppxDSg8k+zF4+Kv+eJyqzEDdbpDg58-=MQcerQ@mail.gmail.com
This commit is contained in:
Tom Lane
2020-09-05 13:17:32 -04:00
parent 8febfd1855
commit a5cc4dab6d
10 changed files with 22 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/bin/pg_dump/pg_backup_custom.c
View File

@@ -619,7 +619,6 @@ _skipData(ArchiveHandle *AH)
size_t blkLen;
char *buf = NULL;
int buflen = 0;
size_t cnt;
blkLen = ReadInt(AH);
while (blkLen != 0)
@@ -638,7 +637,7 @@ _skipData(ArchiveHandle *AH)
buf = (char *) pg_malloc(blkLen);
buflen = blkLen;
}
if ((cnt = fread(buf, 1, blkLen, AH->FH)) != blkLen)
if (fread(buf, 1, blkLen, AH->FH) != blkLen)
{
if (feof(AH->FH))
fatal("could not read from input file: end of file");
@@ -664,9 +663,7 @@ _skipData(ArchiveHandle *AH)
static int
_WriteByte(ArchiveHandle *AH, const int i)
{
int res;
if ((res = fputc(i, AH->FH)) == EOF)
if (fputc(i, AH->FH) == EOF)
WRITE_ERROR_EXIT;
return 1;